Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Cache] fix compatibility with Redis Relay 0.8.1 #57723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

[Cache] fix compatibility with Redis Relay 0.8.1 #57723

merged 1 commit into from
Jul 17, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 14, 2024

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 6.4 milestone Jul 14, 2024
@carsonbot carsonbot changed the title [WIP][Cache] fix Redis Relay tests [Cache] [WIP] fix Redis Relay tests Jul 14, 2024
@xabbuh xabbuh force-pushed the cache-relay-proxy branch 8 times, most recently from 0338c16 to b61ffcf Compare July 15, 2024 09:38
@xabbuh xabbuh changed the title [Cache] [WIP] fix Redis Relay tests [Cache] [WIP] fix compatibility with Redis Relay 0.8.1 Jul 15, 2024
@xabbuh
Copy link
Member Author

xabbuh commented Jul 15, 2024

see cachewerk/relay@v0.8.0...v0.8.1

@xabbuh xabbuh requested a review from nicolas-grekas July 15, 2024 09:41
@nicolas-grekas
Copy link
Member

So the 0.8.0 builds contain the code from 0.7.0?
Doesn't this mean we should compare against 0.8.0 instead when doing the version-compare?

@nicolas-grekas
Copy link
Member

(I'm confused by the diff which doesn't contain anything about the new json methods).

@xabbuh
Copy link
Member Author

xabbuh commented Jul 15, 2024

(I'm confused by the diff which doesn't contain anything about the new json methods).

That's covered by the release notes I guess:

Added experimental support JSON commands

@xabbuh
Copy link
Member Author

xabbuh commented Jul 15, 2024

So the 0.8.0 builds contain the code from 0.7.0?

That's how I read the changes.

Doesn't this mean we should compare against 0.8.0 instead when doing the version-compare?

I don't think so as that means we would generate incompatible proxy code with 0.8.0.

@xabbuh xabbuh changed the title [Cache] [WIP] fix compatibility with Redis Relay 0.8.1 [Cache] fix compatibility with Redis Relay 0.8.1 Jul 17, 2024
@xabbuh xabbuh force-pushed the cache-relay-proxy branch from b61ffcf to 4c9445d Compare July 17, 2024 05:59
@xabbuh xabbuh merged commit b99c855 into symfony:6.4 Jul 17, 2024
8 of 10 checks passed
@xabbuh xabbuh deleted the cache-relay-proxy branch July 17, 2024 06:07
@xabbuh xabbuh mentioned this pull request Jul 17, 2024
Merged
xabbuh added a commit that referenced this pull request Jul 17, 2024
@xabbuh
minor #57745 [Cache] do not use LazyProxyTrait in RelayProxyTrait (xa…
32aab6e 
…bbuh)

This PR was merged into the 7.2 branch.

Discussion
----------

[Cache] do not use LazyProxyTrait in RelayProxyTrait

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

fixes tests after merging #57723 up into the `7.2` branch by taking #57326 into account

Commits
-------

a0a0867 do not use LazyProxyTrait in RelayProxyTrait
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Cache Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot