[Cache] Add optional ClockInterface to ArrayAdapter
#57836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
xabbuh
approved these changes
Jul 26, 2024
nicolas-grekas
approved these changes
Jul 26, 2024
|
Thank you @jasiolpn. |
ClockInterface to ArrayAdapter
Merged
|
Hi there, Regards |
|
Because new features are never ported to patch releases of older versions (they are not bug fixes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
It is common to use
ArrayAdapteras a cache adapter in test environments. Unfortunately, currently cache item expiration is untestable. On the other hand,Psr\Clock\ClockInterfaceand Symfony Clock component are available for some time. I think it would be great if we make use ofClockInterfaceinArrayAdapter.