-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[String] Fixed Quorum plural, and Quora singular in EnglishInflector #57875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[String] Fixed Quorum plural, and Quora singular in EnglishInflector #57875
Conversation
Added rationale, and problem section in description. |
ChatGPT "knowledge" about this matter:
|
As both plurals are valid, I suggest that the EnglishInflector return both, which will be better for use cases able to deal with multiple candidates (like code trying to find the corresponding method in a class for instance, to support methods defined with any valid plural). |
95bfb06
to
a2053f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep quorums first to keep as this is what we return today.
@fabpot For the reverse, quora plural is not inflected back to quorum. This is a new behavior that will be some kind of bugfix. |
…nd never "Quorums"
a2053f6
to
e457717
Compare
Oops, you're right, quora first for Symfony BC. |
Thank you @Dean151. |
When asking English Inflector the plural of Quorum, we get Quora instead of expected Quorums.
Also added the relevant test coverage for it.
Rationale:
ApiPlatform removed their "legacy inflector" and started using Symfony/String inflector instead. Quorum was inflected to Quorums with Api Platform legacy inflection. Therefore, the migration to Symfony inflection introduce breaking changes (with possible workarounds)
Problem:
After discussion on Slack, it turns out that Quora could be a valid plural, as explained on Wiktionary: https://en.wiktionary.org/wiki/quorum#Noun
Therefore:
@xabbuh suggest that native speakers define which one is the most widely used to decide if this change is a good idea, or not. Debate is open :)
Proposed solution: