[Uid] Ensure UuidV1 is created in lowercase #57887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
because of my comment in #57878 (comment), I would suggest considering it as a bugfix |
derrabus
approved these changes
Jul 31, 2024
xabbuh
approved these changes
Jul 31, 2024
|
Do you want me to change the target branch ? |
|
we should be able to do that while merging |
b75d6a0 to
9abfd25
Compare
|
Thank you @smnandre. |
This was referenced Aug 30, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
$this->uidis in lowercase in UuidV1 (see #57878 for context)(strtolower is already called in the parent::__construct... but not when $args is null. And the uuid extension generates uppercase values --at least sometimes--).
Not sure if should be considered a "bug" / which version to flag ?