[DependencyInjection] Fix importing PHP configs in the prepend extension method #57937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @yceruto. |
stof
reviewed
Aug 7, 2024
| @@ -92,6 +92,7 @@ public function import(mixed $resource, ?string $type = null, bool|string $ignor | |||
| } | |||
| } finally { | |||
| --$this->importing; | |||
| $this->loadExtensionConfigs(); | |||
There was a problem hiding this comment.
why do we need this here (even in case of exception) ?
There was a problem hiding this comment.
because there is a return statement inside the try block, so there is no other chance to load the collected ext config after --$this->importing; instruction
There was a problem hiding this comment.
btw, it's not about the exception at all, but if it happens I guess it doesn't matter if we try to prepend some configs afterward
|
It doesn't work for more than one bundle Only the last bundle is taken into account bin/console doctrine:mapping:info
Found 3 mapped entities:
[OK] AcMarche\Cap\Entity\Commercant
[OK] AcMarche\Cap\Entity\CommercantGallery
[OK] AcMarche\Cap\Entity\CommercioBottinABundle class ABundle extends AbstractBundle
{
public function getPath(): string
{
return \dirname(__DIR__);
}
public function loadExtension(array $config, ContainerConfigurator $container, ContainerBuilder $builder): void
{
$container->import('../config/services.php');
}
public function prependExtension(ContainerConfigurator $container, ContainerBuilder $builder): void
{
$container->import('../config/packages/doctrine.php');
}
}//doctrine.php
return static function (DoctrineConfig $doctrine) {
$doctrine->dbal()
->connection('default')
->url(env('DATABASE_URL')->resolve());
$em = $doctrine->orm()->entityManager('default');
$doctrine->dbal()->defaultConnection('default');
$em->connection('default');
$em->mapping('AcMarcheBottin')
->isBundle(false)
->type('attribute')
->dir('%kernel.project_dir%/src/AcMarche/Bottin/src/Entity')
->prefix('AcMarche\Bottin')
->alias('AcMarcheBottin');
};BBundle class ABundle extends AbstractBundle
{
//...
//the same as above
}//doctrine.php
return static function (DoctrineConfig $doctrine) {
$doctrine->dbal()
->connection('cap')
->url(env('DATABASE_URL_CAP')->resolve());
$em = $doctrine->orm()->entityManager('cap');
$em->connection('cap');
$em->mapping('AcMarcheCap')
->isBundle(false)
->type('attribute')
->dir('%kernel.project_dir%/src/AcMarche/Cap/src/Entity')
->prefix('AcMarche\Cap')
->alias('AcMarcheCap');
}; |
|
@jfsenechal can you open a new issue with details so I can take a look? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this nesting case during #52843.