[Validator] Add D regex modifier in relevant validators
#57984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd go with a bugfix personally. WDYT @symfony/mergers ? |
|
I agree with a bugfix as it also ensures some kind of security also IMHO |
|
👍 for treating this as a bugfix |
389d337 to
1140b29
Compare
1140b29 to
ed8831a
Compare
|
Alright, I rebased on 5.4. The merger may encounter a few conflicts during upmerge, especially with the Time constraint where a new regex is added in upper branches. If necessary, I'll provide a follw-up PR for it and add the relevant test case |
src/Symfony/Component/Validator/Tests/Constraints/CardSchemeValidatorTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Tests/Constraints/CardSchemeValidatorTest.php
Outdated
Show resolved
Hide resolved
ed8831a to
7d1032b
Compare
nicolas-grekas
approved these changes
Aug 13, 2024
|
Thank you @alexandre-daubois. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #57908 (comment). I'm not sure if this should be considered a bugfix or a feature.