[DependencyInjection] Fix issue between decorator and service locator index #58000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
added a commit
to lyrixx/test
that referenced
this pull request
Aug 13, 2024
lyrixx
added a commit
to lyrixx/test
that referenced
this pull request
Aug 13, 2024
96f9ae7 to
39b216d
Compare
39b216d to
8a842cb
Compare
|
@nicolas-grekas Thanks for the review ; ✅ |
nicolas-grekas
approved these changes
Aug 21, 2024
src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
Outdated
Show resolved
Hide resolved
8a842cb to
b2e8399
Compare
chalasr
approved these changes
Aug 21, 2024
|
Thank you @lyrixx. |
This was referenced Aug 30, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not finished yet. I want to gather feedback before writing tests.
To explain what is wrong, I create a reproducer.
Basically, when we decorates a services, we replace the old ID with a new ID in the DIC.
Then, when we build a service locator, we use the new ID. This is really not handy because our code
is dependant on the new name or old name, depending if the decorator is here or not!
This issue discribe very well the issue: #53174
So in this PR, I save the original ID in the decorator definition. Then I used this initial ID to build the
$indexof theservice locator.
With this PR and the reproducer, I got what would be expected