Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DependencyInjection] fix tests #58043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024
Merged

[DependencyInjection] fix tests #58043

merged 1 commit into from
Aug 22, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 20, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 7.1 milestone Aug 20, 2024
@carsonbot carsonbot changed the title [DependencyInjection] fix tests [DependencyInjection]  fix tests Aug 20, 2024
@xabbuh
Copy link
Member Author

xabbuh commented Aug 20, 2024

@MatTheCat This change is needed to make the tests pass after #57493. Though I wonder if that really is the desired behaviour.

@xabbuh xabbuh changed the title [DependencyInjection]  fix tests [DependencyInjection] fix tests Aug 20, 2024
@xabbuh xabbuh requested a review from nicolas-grekas August 20, 2024 12:04
@MatTheCat
Copy link
Contributor

http://symfony.com/schema/dic/services’s XSD allows for a foreign group which is a sequence of elements from another namespace, so this actually looks correct to me 🤔

@xabbuh
Copy link
Member Author

xabbuh commented Aug 20, 2024

Do the another and another2 elements really inherit the namespace from the parent foo element?

@xabbuh xabbuh merged commit 00f1b63 into symfony:7.1 Aug 22, 2024
8 of 10 checks passed
@xabbuh xabbuh deleted the pr-57493 branch August 22, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants