Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] Add more precise PHPDoc on constraints #58049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

alexandre-daubois
Copy link
Member

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not (but please do go as far as adding non-empty-string to every single string arguments in the codebase... :) )

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do go as far as adding non-empty-string to every single string arguments in the codebase

Oops, I meant "do NOT" 😆

@alexandre-daubois
Copy link
Member Author

No worries, that's what I understood 😄

@fabpot
Copy link
Member

fabpot commented Aug 22, 2024

Thank you @alexandre-daubois.

@fabpot fabpot merged commit f9b47a0 into symfony:7.2 Aug 22, 2024
7 of 10 checks passed
@alexandre-daubois alexandre-daubois deleted the better-phpdoc branch August 22, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants