Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SecurityBundle] Deprecate XML-configured custom authenticators and providers under security namespace #58083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[SecurityBundle] Deprecate XML-configured custom authenticators and providers under security namespace #58083

wants to merge 3 commits into from

Conversation

MatTheCat
Copy link
Contributor

@MatTheCat MatTheCat commented Aug 25, 2024 •
edited
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? yes
Issues N/A
License MIT

#57493 allowed XML-configured custom authenticators and providers to stay under the security namespace to avoid a BC break. Now that it got merged into 7.2 this can be deprecated.

Not sure about wordings; feel free to suggest.

@MatTheCat MatTheCat requested a review from chalasr as a code owner August 25, 2024 08:37
@carsonbot carsonbot added this to the 7.2 milestone Aug 25, 2024
@MatTheCat MatTheCat force-pushed the deprecate-missing-namespace branch 2 times, most recently from 3e8318f to 7c68407 Compare August 25, 2024 08:45
@chalasr
Copy link
Member

chalasr commented Aug 25, 2024

CHANGELOG/UPGRADE entries as well as the PR title should tell this is about XSD. Markdown files could also include before/after exemples for more clarity.

@MatTheCat MatTheCat changed the title [SecurityBundle] Deprecate custom authenticators and providers under security namespace [SecurityBundle] Deprecate XML-configured custom authenticators and providers under security namespace Aug 25, 2024
@MatTheCat MatTheCat force-pushed the deprecate-missing-namespace branch 2 times, most recently from 0aa6719 to 9b9c6b6 Compare August 25, 2024 16:40
@MatTheCat
Copy link
Contributor Author

Mentioned this is about XML configuration and added an example diff in the changelog and upgrade files.

@MatTheCat MatTheCat force-pushed the deprecate-missing-namespace branch 2 times, most recently from 44d77b5 to 6c518a6 Compare September 17, 2024 09:26
@MatTheCat MatTheCat force-pushed the deprecate-missing-namespace branch 2 times, most recently from d83573e to 07c4b5b Compare October 5, 2024 10:53
@MatTheCat MatTheCat force-pushed the deprecate-missing-namespace branch from 07c4b5b to 3323de9 Compare October 26, 2024 10:16
@MatTheCat MatTheCat force-pushed the deprecate-missing-namespace branch from 3323de9 to 23d87fe Compare November 6, 2024 20:58
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@MatTheCat MatTheCat force-pushed the deprecate-missing-namespace branch from 23d87fe to 43e3ca3 Compare November 20, 2024 14:26
@MatTheCat MatTheCat closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Deprecation SecurityBundle Status: Needs Review
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
5 participants
@MatTheCat @chalasr @nicolas-grekas @fabpot @carsonbot