Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mailer] add Mailtrap bridge #58252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2024
Merged

[Mailer] add Mailtrap bridge #58252

merged 1 commit into from
Sep 18, 2024

Conversation

kbond
Copy link
Member

@kbond kbond commented Sep 13, 2024 •
edited by OskarStark
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues n/a
License MIT

This adds a new mailer bridge for Mailtrap (their sending feature - not email testing).

Documentation

Recipe

@carsonbot carsonbot added this to the 7.2 milestone Sep 13, 2024
This was referenced Sep 13, 2024
Merged
Merged
@kbond kbond force-pushed the feat/mailtrap branch 2 times, most recently from 6553eea to c393ff9 Compare September 13, 2024 03:06
OskarStark
OskarStark reviewed Sep 13, 2024
View reviewed changes
@kbond
Copy link
Member Author

kbond commented Sep 13, 2024

Thanks for the reviews!

@kbond kbond mentioned this pull request Sep 13, 2024
Merged
2 tasks
@OskarStark OskarStark requested a review from fabpot September 16, 2024 12:07
@fabpot
Copy link
Member

fabpot commented Sep 18, 2024

Thank you @kbond.

@fabpot fabpot merged commit 31aa837 into symfony:7.2 Sep 18, 2024
5 of 10 checks passed
@kbond kbond deleted the feat/mailtrap branch September 18, 2024 16:13
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Sep 19, 2024
@OskarStark
feature #20217 [Mailer] add Mailtrap docs (kbond)
8019920 
This PR was merged into the 7.2 branch.

Discussion
----------

[Mailer] add Mailtrap docs

Documentation for
* symfony/symfony#58252

Commits
-------

e425caf [Mailer] add Mailtrap docs
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
@gaalferov
Copy link

Hi everyone, Mailtrap already has PHP SDK and integration with Symfony framework https://github.com/railsware/mailtrap-php/tree/main/src/Bridge/Symfony
@fabpot Can I help with improving the current code and supporting all the features of this provider? (custom headers,etc)

@stof
Copy link
Member

stof commented Nov 4, 2024

@gaalferov official mailer bridges are not about being full SDKs for the API of a provider, supporting all features supported by that API. They are about implementing the Mailer abstraction using that provider, so that you can write the same code using symfony/mailer and symfony/mime and have it working with those providers.
For instance, that's why template variables are not supported in any such bridge, because each provider has its own syntax for the content of templates, and so we could not build a proper abstraction in symfony/mailer that would be backed by such provider templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
7 participants
@kbond @fabpot @gaalferov @stof @OskarStark @xabbuh @carsonbot