[ExpressionLanguage] Fix matches to handle booleans being used as regexp #58261
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "7.2 for features / 5.4, 6.4, and 7.1 for bug fixes". Cheers! Carsonbot |
src/Symfony/Component/ExpressionLanguage/Tests/Node/BinaryNodeTest.php
Outdated
Show resolved
Hide resolved
3faa641 to
e0fbc7e
Compare
|
Thank you @ivantsepp. |
|
Thanks for reviewing and merging! |
I'm marking this as a bug fix but this could be seen as a "new feature" as existing
matchessyntax functionality works just fine.I wanted to build on top of the work done at #45875. This handles invalid regular expressions and also does an extra check inside the
compilemethod. It checks the right hand side for aConstantNodeand validates that it's a valid regexp. The idea is that we can go even further and check forBinaryNodebecause in most cases, this is an invalid regexp since a boolean usually returned. The exception is~which is for string concatenation since that could result in a valid regexp.This extra check could help prevent invalid expressions like
"a" matches ("/a/" || "/b/")where one could mistake"/a/" || "/b/"as being a valid regexp (when the correct approach would've been"a" matches "/a|b/")