Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Seldaek
Copy link
Member

@Seldaek Seldaek commented Oct 4, 2024

Special PR for @nicolas-grekas with a failing test

Note how the first command passes, but the second fails

../../../../vendor/bin/simple-phpunit --filter testDoesNotThrowOnDestructIfExceptionCaughtEarlierWithGetStatusCode
../../../../vendor/bin/simple-phpunit --filter testDoesNotThrowOnDestructIfExceptionCaughtEarlierEvenWithoutGetStatusCode

I manually trigger __destruct in the test, but if not it then throws at the end of the phpunit execution.

calling $response->getStatusCode() to trigger response::initialize is the only difference between the two test cases.

@carsonbot carsonbot added this to the 7.2 milestone Oct 4, 2024
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@fabpot fabpot modified the milestones: 7.3, 7.4 May 26, 2025
@nicolas-grekas nicolas-grekas modified the milestones: 7.4, 8.1 Nov 16, 2025
@nicolas-grekas nicolas-grekas modified the milestones: 8.1, 6.4 Dec 7, 2025
@nicolas-grekas nicolas-grekas changed the base branch from 8.1 to 6.4 December 7, 2025 14:41
@nicolas-grekas nicolas-grekas changed the base branch from 6.4 to 7.3 December 7, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants