[PhpUnitBridge] Use total for asserting deprecation count when a group is not defined
#58499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Oct 8, 2024
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | - |
| License | MIT |
lyrixx
commented
Oct 8, 2024
| @@ -96,7 +96,7 @@ private function __construct(array $thresholds = [], string $regex = '', array $ | |||
| } | |||
| foreach ($groups as $group) { | |||
| if (!isset($this->thresholds[$group])) { | |||
| $this->thresholds[$group] = 999999; | |||
| $this->thresholds[$group] ??= $this->thresholds['total'] ?? 999999; | |||
There was a problem hiding this comment.
I have an app, with a LOT OF deprecation notice.
I tried to increased the value in our setup
<server name="SYMFONY_DEPRECATIONS_HELPER" value="max[total]=2000000&verbose=0" />
but it did not worked, because the default value is 999999.
And this is a bit "WTF", because it failed, and I had no clue why.
I had hard time to understand why.
In our app, we have theses numbers:
array:6 [
"unsilenced" => 0
"self" => 3
"direct" => 646
"indirect" => 1002531
"legacy" => 0
"other" => 686
]
62087c1 to
3e87ba4
Compare
stof
approved these changes
Oct 8, 2024
total for asserting deprecation count when a group is not defined
alexandre-daubois
approved these changes
Oct 9, 2024
|
This should be documented in the changelog file. |
…oup is not defined
3e87ba4 to
02d1110
Compare
Thanks, fixed 👍🏼 |
xabbuh
approved these changes
Oct 21, 2024
|
Thank you @lyrixx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.