[Lock] Enabled usage of EVALSHA and LOAD SCRIPT over regular EVAL #58533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dciprian-petrisor
commented
Oct 10, 2024
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | Fix #58452 |
| License | MIT |
66b90b7 to
e67c2a1
Compare
stof
reviewed
Oct 11, 2024
OskarStark
reviewed
Oct 17, 2024
nicolas-grekas
approved these changes
Oct 22, 2024
|
@nicolas-grekas I believe the last commit covers all points, let me know if there's something else. |
a447007 to
2a846cd
Compare
|
Thank you @dciprian-petrisor. |
|
This seems a serious BC break #59087 |
|
@ro0NL looking into it to provide a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.