[Notifier] support SmsMessage with 'from' set
#58539
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
SmsMessage with 'from' set
|
Can someone give me a pointer on how to solve the psalm error? |
src/Symfony/Component/Notifier/Bridge/FakeSms/FakeSmsEmailTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Bridge/FakeSms/FakeSmsEmailTransport.php
Outdated
Show resolved
Hide resolved
Fixes `Error Email does not comply with addr-spec of RFC 2822` See: symfony#58535
| throw new UnsupportedMessageTypeException(__CLASS__, SmsMessage::class, $message); | ||
| } | ||
|
|
||
| $email = (new Email()) | ||
| ->from($message->getFrom() ?: $this->from) | ||
| ->from($this->from) |
There was a problem hiding this comment.
can you explain this change? it looks suspicious to me
There was a problem hiding this comment.
The change looks valid to me. At least, there is nothing indicating that the $from property of the SmsMessage class has to be a valid e-mail address and thus we IMO must not use it as such in the FakeSmsEmailTransport.
|
Closing here due to lack of activity. Feel free to reopen and thanks for proposing 👍 |
Fixes
Error Email does not comply with addr-spec of RFC 2822See
Email does not comply with addr-spec of RFC 2822#58535