[Console][Messenger] Add $seconds to keepalive() methods
#58552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$seconds to keepalive() methods$seconds to keepalive() methods
57185ca to
e3beb18
Compare
fabpot
approved these changes
Oct 13, 2024
chalasr
requested changes
Oct 13, 2024
Member
chalasr
left a comment
There was a problem hiding this comment.
The component changelog needs to mention the new method
OskarStark
reviewed
Oct 13, 2024
src/Symfony/Component/Messenger/Transport/Receiver/KeepaliveReceiverInterface.php
Show resolved
Hide resolved
OskarStark
reviewed
Oct 13, 2024
Contributor
Author
As this whole feature is not released yet, I thought the changes here would be covered by the initial changelog entries about adding keepalive / alarm support since from component user perspective it's a single new feature – but ok, I will add those. 👍 |
fabpot
approved these changes
Oct 14, 2024
Member
|
Thank you @valtzu. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the transport aware for how long (at minimum) the message should be kept alive.
F.e. when extending SQS visibility timeout, you need to pass the visibility timeout (seconds) as parameter. If you pass a value which is less than alarm interval, SQS would resend the message too early. By making the transport aware of when the next keepalive call will happen we'll be able to do some assertions/clamping to improve DX.
This is a prerequisite for #58483.