[HttpClient] Fix typo in deprecation message #58625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Oct 22, 2024
I didn't check with a real application but as I read the code it should indeed work like this as long as you don't replace Symfony's |
|
Thank you @Seldaek. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a typo fix from #54806
This confused me initially because I thought I had to configure it on a wrapper, so add one more layer, but couldn't find a logging wrapper client..
Anyway @xabbuh one more question do I understand it correctly that if one just uses autowiring and the framework.http_client config to create a client, then the loggers will be set by default and nothing has to be done? No need to call setLogger explicitly on the client right?