Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Mailer][Notifier] Add webhooks signature verification on Sweego bridges #58651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2024
Merged

[Mailer][Notifier] Add webhooks signature verification on Sweego bridges #58651

merged 1 commit into from
Dec 6, 2024

Conversation

welcoMattic
Copy link
Member

@welcoMattic welcoMattic commented Oct 24, 2024 •
edited by OskarStark
Loading

Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #...
License MIT

This PR follows the 2 previous ones (#57431, and #58322). It brings webhook signature verification to improve security.

Sweego documentation about webhook is here https://learn.sweego.io/docs/webhooks/webhook_signature

@carsonbot carsonbot added this to the 7.2 milestone Oct 24, 2024
@welcoMattic welcoMattic changed the title Add webhooks signature verification on Sweego bridges [Notifier][Mailer] Add webhooks signature verification on Sweego bridges Oct 24, 2024
@welcoMattic welcoMattic force-pushed the sweego-webhooks-signature branch from 9670421 to 2fef440 Compare October 24, 2024 12:16
@carsonbot carsonbot changed the title [Notifier][Mailer] Add webhooks signature verification on Sweego bridges Add webhooks signature verification on Sweego bridges Oct 24, 2024
@carsonbot carsonbot changed the title Add webhooks signature verification on Sweego bridges [Mailer][Notifier] Add webhooks signature verification on Sweego bridges Oct 24, 2024
@welcoMattic welcoMattic added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Oct 24, 2024
@welcoMattic welcoMattic force-pushed the sweego-webhooks-signature branch from 2fef440 to 482fd9e Compare October 30, 2024 16:37
stof
stof reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests covering this logic ?

@fabpot
Copy link
Member

fabpot commented Nov 9, 2024

@welcoMattic In addition to adding new tests, can you have a look at the existing ones that are broken now.

@fabpot
Copy link
Member

fabpot commented Nov 18, 2024

@welcoMattic Last chance to include this PR in 7.2.

@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@welcoMattic
Copy link
Member Author

I couldn't make it for 7.2, sorry. Let's remove it from FF.

(I'm on my honeymoon trip until 28th nov.)

@xabbuh xabbuh removed the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Nov 23, 2024
@fabpot
Copy link
Member

fabpot commented Nov 23, 2024

(I'm on my honeymoon trip until 28th nov.)

Enjoy!

@welcoMattic welcoMattic force-pushed the sweego-webhooks-signature branch 5 times, most recently from 3ac184d to 25f6b53 Compare December 4, 2024 21:30
@welcoMattic
Copy link
Member Author

I've added tests and fix existing ones. Failure is related to something on HttpClient itself, not related to this PR.

@welcoMattic welcoMattic requested review from fabpot and Nyholm December 5, 2024 10:27
@welcoMattic welcoMattic force-pushed the sweego-webhooks-signature branch from 25f6b53 to 9c59199 Compare December 5, 2024 10:28
Nyholm
Nyholm approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just one comment

@fabpot
Copy link
Member

fabpot commented Dec 6, 2024

Thank you @welcoMattic.

@fabpot fabpot merged commit 3a804f5 into symfony:7.3 Dec 6, 2024
9 of 10 checks passed
@fabpot fabpot mentioned this pull request Dec 6, 2024
Closed
@welcoMattic welcoMattic deleted the sweego-webhooks-signature branch January 10, 2025 09:14
@fabpot fabpot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@stof stof Awaiting requested review from stof

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

@fabpot fabpot Awaiting requested review from fabpot

Assignees
No one assigned
Labels
Feature Mailer Notifier Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
7 participants
@welcoMattic @fabpot @stof @OskarStark @Nyholm @xabbuh @carsonbot