[Process] Fix handling empty path found in the PATH env var with ExecutableFinder #58711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about: diff --git a/src/Symfony/Component/Process/Tests/ExecutableFinderTest.php b/src/Symfony/Component/Process/Tests/ExecutableFinderTest.php
index a1b8d6d54b..5052fc0d6b 100644
--- a/src/Symfony/Component/Process/Tests/ExecutableFinderTest.php
+++ b/src/Symfony/Component/Process/Tests/ExecutableFinderTest.php
@@ -138,6 +138,21 @@ class ExecutableFinderTest extends TestCase
$this->assertSamePath($target.'.BAT', $result);
}
+ public function testEmptyDirInPath()
+ {
+ putenv(sprintf('PATH=%s:', \dirname(\PHP_BINARY)));
+
+ touch('executable');
+ chmod('executable', 0700);
+
+ $finder = new ExecutableFinder();
+ $result = $finder->find('executable');
+
+ $this->assertSame('./executable', $result);
+
+ unlink('executable');
+ }
+
private function assertSamePath($expected, $tested)
{
if ('\\' === \DIRECTORY_SEPARATOR) {The result before your fix: After this fix: |
6e518ec to
c40ec9c
Compare
|
Perfect thanks! PR updated. |
alexandre-daubois
approved these changes
Oct 30, 2024
nicolas-grekas
added a commit
that referenced
this pull request
Nov 4, 2024
…y` block (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Process] Improve test cleanup by unlinking in a `finally` block | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Follwup for #58711, I realized afterwards that we may unlink in `finally` block to ensure proper test clean up in case something goes wrong. Commits ------- 5c547c9 [Process] Improve test cleanup by unlinking in a `finally` block
This was referenced Nov 6, 2024
Merged
Merged
Merged
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.