[HttpFoundation] Fix support for \SplTempFileObject in BinaryFileResponse
#58712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\SplTempFileObject in BinaryFileResponse
xabbuh
reviewed
Nov 4, 2024
21b6c7b to
a104d50
Compare
|
Thank you @elementaire. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can not call some methods with an object of
\SplTempFileObject(). We get this error:[...] stat failed for php://temp.I have checked the code against methods listed in this note.
I have found:
getMTime()called inBinaryFileResponse::setAutoLastModified()getSize()called inBinaryFileResponse::prepare()isReadable()called inBinaryFileResponse::setFile()(already safe)I have updated the unit test and patched the class
BinaryFileResponse.Note: calling
SplFileObject::fstat()givesmtimeequals to0. I think it is nonsense to use that as value for last modified. I have decided to usetime()because i guess, we can not do better. Indeed, we have no idea how much time have passed between making the temp file and the call tosetAutoLastModified()by the developper.