Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier] Fix GoIpTransport #58862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[Notifier] Fix GoIpTransport #58862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/Symfony/Component/HttpFoundation/Tests/RequestTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2668,16 +2668,6 @@ public function testReservedFlags()
$this->assertNotSame(0b10000000, $value, sprintf('The constant "%s" should not use the reserved value "0b10000000".', $constant));
}
}

/**
* @group legacy
*/
public function testInvalidUriCreationDeprecated()
{
$this->expectDeprecation('Since symfony/http-foundation 6.3: Calling "Symfony\Component\HttpFoundation\Request::create()" with an invalid URI is deprecated.');
$request = Request::create('/invalid-path:123');
$this->assertEquals('http://localhost/invalid-path:123', $request->getUri());
}
}

class RequestContentProxy extends Request
Expand Down
11 changes: 5 additions & 6 deletions src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public function testFromDsnWithMixDsnQueryOptions()

$this->assertEquals(
Connection::fromDsn('redis://localhost/queue/group1/consumer1', ['consumer' => 'specific-consumer'], $this->createRedisMock()),
Connection::fromDsn('redis://localhost/queue/group1/consumer1', [], $this->createRedisMock()))
Connection::fromDsn('redis://localhost/queue/group1/consumer1', [], $this->createRedisMock())
);
}

Expand Down Expand Up @@ -439,8 +439,7 @@ public function testFromDsnOnUnixSocketWithUserAndPassword()
'delete_after_ack' => true,
'host' => '/var/run/redis/redis.sock',
'port' => 0,
'user' => 'user',
'pass' => 'password',
'auth' => ['user', 'password'],
], $redis),
Connection::fromDsn('redis://user:password@/var/run/redis/redis.sock', ['stream' => 'queue', 'delete_after_ack' => true], $redis)
);
Expand All @@ -460,7 +459,7 @@ public function testFromDsnOnUnixSocketWithPassword()
'delete_after_ack' => true,
'host' => '/var/run/redis/redis.sock',
'port' => 0,
'pass' => 'password',
'auth' => 'password',
], $redis),
Connection::fromDsn('redis://password@/var/run/redis/redis.sock', ['stream' => 'queue', 'delete_after_ack' => true], $redis)
);
Expand All @@ -480,7 +479,7 @@ public function testFromDsnOnUnixSocketWithUser()
'delete_after_ack' => true,
'host' => '/var/run/redis/redis.sock',
'port' => 0,
'user' => 'user',
'auth' => 'user',
], $redis),
Connection::fromDsn('redis://user:@/var/run/redis/redis.sock', ['stream' => 'queue', 'delete_after_ack' => true], $redis)
);
Expand All @@ -494,7 +493,7 @@ private function createRedisMock(): \Redis
->willReturn(true);
$redis->expects($this->any())
->method('isConnected')
->willReturnOnConsecutiveCalls(false, true);
->willReturnOnConsecutiveCalls(false, true, true);

return $redis;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Notifier/Bridge/GoIp/GoIpTransport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ protected function doSend(MessageInterface $message): SentMessage
throw new LogicException(sprintf('The "%s" transport does not support the "From" option.', __CLASS__));
}

$response = $this->client->request('GET', $this->getEndpoint(), [
$response = $this->client->request('GET', 'https://'.$this->getEndpoint(), [
'query' => [
'u' => $this->username,
'p' => $this->password,
Expand Down
Loading