Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[OptionsResolver] Allow Union/Intersection Types in Resolved Closures #58917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[OptionsResolver] Allow Union/Intersection Types in Resolved Closures #58917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/OptionsResolver/OptionsResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ public function setDefault(string $option, mixed $value): static
return $this;
}

if (isset($params[0]) && null !== ($type = $params[0]->getType()) && self::class === $type->getName() && (!isset($params[1]) || (($type = $params[1]->getType()) instanceof \ReflectionNamedType && Options::class === $type->getName()))) {
if (isset($params[0]) && ($type = $params[0]->getType()) instanceof \ReflectionNamedType && self::class === $type->getName() && (!isset($params[1]) || (($type = $params[1]->getType()) instanceof \ReflectionNamedType && Options::class === $type->getName()))) {
// Store closure for later evaluation
$this->nested[$option][] = $value;
$this->defaults[$option] = [];
Expand Down
22 changes: 22 additions & 0 deletions src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,28 @@ public function testClosureWithoutParametersNotInvoked()
$this->assertSame(['foo' => $closure], $this->resolver->resolve());
}

public function testClosureWithUnionTypesNotInvoked()
{
$closure = function (int|string|null $value) {
Assert::fail('Should not be called');
};

$this->resolver->setDefault('foo', $closure);

$this->assertSame(['foo' => $closure], $this->resolver->resolve());
}

public function testClosureWithIntersectionTypesNotInvoked()
{
$closure = function (\Stringable&\JsonSerializable $value) {
Assert::fail('Should not be called');
};

$this->resolver->setDefault('foo', $closure);

$this->assertSame(['foo' => $closure], $this->resolver->resolve());
}

public function testAccessPreviousDefaultValue()
{
// defined by superclass
Expand Down
Loading