[RateLimiter] Add RateLimiterFactoryInterface
#58939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2bd3a61 to
17fb0fe
Compare
17fb0fe to
7e7f4d7
Compare
xabbuh
reviewed
Jan 18, 2025
src/Symfony/Bundle/FrameworkBundle/Resources/config/rate_limiter.php
Outdated
Show resolved
Hide resolved
7e7f4d7 to
66a1304
Compare
66a1304 to
619c0eb
Compare
xabbuh
approved these changes
Jan 18, 2025
OskarStark
approved these changes
Jan 18, 2025
fabpot
approved these changes
Feb 7, 2025
|
Thank you @alexandre-daubois. |
chalasr
added a commit
that referenced
this pull request
Mar 7, 2025
…ace` (kbond) This PR was merged into the 7.3 branch. Discussion ---------- [FrameworkBundle] fix autowiring `RateLimiterFactoryInterface` | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix bug in #58939 | License | MIT Fixes a small bug from #58939. Confirmed with `@alexandre`-daubois this was the intention. Commits ------- 7130a9f [FrameworkBundle] fix autowiring `RateLimiterFactoryInterface`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes sense to create this interface for both being able to implement your own factory logic as well as type-hint against an interface when injecting it.
I would however not make the class non-final as suggested in the issue. The interface only contains one method with not that much logic inside the current implementation.