Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console] Add support of millisecondes for formatTime #58946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2024
Merged

[Console] Add support of millisecondes for formatTime #58946

merged 1 commit into from
Dec 10, 2024

Conversation

SebLevDev
Copy link
Contributor

@SebLevDev SebLevDev commented Nov 20, 2024 •
edited
Loading

Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
License MIT

Description

This pull request introduces support for formatting time durations down to milliseconds in the Helper::formatTime() method. Previously, the method only supported seconds and larger units (minutes, hours, days). The new implementation adds:

  1. Support for milliseconds when the input is a fractional value (e.g., 1.456 → 1 sec, 456 ms).
  2. Accurate rounding for milliseconds.
  3. Respect for the precision parameter, limiting the number of time components displayed in the output.

Examples

Helper::formatTime(0.001);        // "1 ms"
Helper::formatTime(1.456);        // "1 s, 456 ms"
Helper::formatTime(125.789, 2);   // "2 min, 5 s"
Helper::formatTime(172799.999, 4); // "1 d, 23 h, 59 min, 59 s"
Helper::formatTime(0.0005);       // "< 1 ms"

@SebLevDev SebLevDev requested a review from chalasr as a code owner November 20, 2024 13:37
@carsonbot carsonbot added this to the 7.3 milestone Nov 20, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Feature/console helper formattime ms [Console] Feature/console helper formattime ms Nov 20, 2024
@OskarStark OskarStark changed the title [Console] Feature/console helper formattime ms [Console] Add support of millisecondes for formatTime Nov 20, 2024
fmarchalemisys
fmarchalemisys reviewed Nov 21, 2024
View reviewed changes
@carsonbot carsonbot changed the title [Console] Add support of millisecondes for formatTime [Console] Add support of millisecondes for formatTime Nov 21, 2024
94noni
94noni reviewed Nov 21, 2024
View reviewed changes
@SebLevDev SebLevDev requested a review from 94noni November 25, 2024 13:30
fabpot
fabpot requested changes Nov 27, 2024
View reviewed changes
@fabpot
Copy link
Member

fabpot commented Nov 27, 2024

While doing this, I would change the other units to be more in line with standard scientific notation: ms, s, min, h, and d.

@SebLevDev
Copy link
Contributor Author

While doing this, I would change the other units to be more in line with standard scientific notation: ms, s, min, h, and d.

Can this change not be considered a BC Break?

@fabpot
Copy link
Member

fabpot commented Nov 27, 2024

While doing this, I would change the other units to be more in line with standard scientific notation: ms, s, min, h, and d.

Can this change not be considered a BC Break?

Sure, this is pure display, so no BC promise.

@SebLevDev
Copy link
Contributor Author

Hello everyone,

Thank you for the feedback, especially @fabpot for the suggestion about aligning the units with standard scientific notation (ms, s, min, h, d).

I’m a bit unsure about the next steps here. Should I proceed with the proposed changes for all the units as suggested, or wait for further input from other reviewers to ensure this aligns with everyone’s expectations?

Any additional guidance or confirmation would be greatly appreciated to avoid conflicting directions.

Thanks in advance!

@fabpot
Copy link
Member

fabpot commented Dec 9, 2024

Hello everyone,

Thank you for the feedback, especially @fabpot for the suggestion about aligning the units with standard scientific notation (ms, s, min, h, d).

I’m a bit unsure about the next steps here. Should I proceed with the proposed changes for all the units as suggested, or wait for further input from other reviewers to ensure this aligns with everyone’s expectations?

Any additional guidance or confirmation would be greatly appreciated to avoid conflicting directions.

Thanks in advance!

Please, go ahead and make the suggested changes.

@fabpot fabpot force-pushed the feature/console_helper_formattime_ms branch from 44369db to eac7d49 Compare December 10, 2024 11:41
@fabpot
Copy link
Member

fabpot commented Dec 10, 2024

Thank you @SebLevDev.

@fabpot fabpot merged commit d1a3375 into symfony:7.3 Dec 10, 2024
6 of 7 checks passed
@fabpot fabpot mentioned this pull request Dec 10, 2024
Closed
@alexandre-daubois alexandre-daubois mentioned this pull request Dec 10, 2024
Merged
fabpot added a commit that referenced this pull request Dec 10, 2024
@fabpot
minor #59158 [Console] Fix time display in tests (alexandre-daubois)
57c8040 
This PR was merged into the 7.3 branch.

Discussion
----------

[Console] Fix time display in tests

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Fixes CI after #58946.

Commits
-------

049bc63 [Console] Fix time display in tests
@fabpot fabpot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@94noni 94noni 94noni approved these changes

@fmarchalemisys fmarchalemisys fmarchalemisys approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Console Feature Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
6 participants
@SebLevDev @carsonbot @fabpot @94noni @fmarchalemisys @OskarStark