[VarDumper] Add casters for object-converted resources #59035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13e4077 to
1ff8865
Compare
stof
reviewed
Nov 29, 2024
7096471 to
24c00c5
Compare
ed8fdf2 to
d382421
Compare
|
Revamped the PR, so most things are still in ResourceCaster now. The regression in PHP has been reported to php/php-src#16990, and most casters now "simply" map infos to |
9830222 to
8ec4800
Compare
stof
reviewed
Nov 29, 2024
34d936d to
d0b95fc
Compare
|
Marked all casters as internal and added |
5cf62d8 to
27a573b
Compare
4952bc6 to
7ea55ce
Compare
7ea55ce to
afbb31e
Compare
|
Solved by silencing |
ec86ba0 to
9d65675
Compare
|
The |
fabpot
added a commit
that referenced
this pull request
Dec 6, 2024
This PR was merged into the 6.4 branch. Discussion ---------- Add CI job for PHP 8.5 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Enables PHP 8.5 nightlies on the CI. What motivated this early addition is the continuous effort of converting resources to actual classes. PHP 8.5 already embeds features like https://wiki.php.net/rfc/directory-opaque-object, which could already be handled in PRs such as #59035. Also we'll be able to fix future deprecations as soon as they appear during the next year. Commits ------- 15d56bb Add an experimental CI job for PHP 8.5
9d65675 to
94aa998
Compare
| { | ||
| if (\PHP_VERSION_ID < 80402 && !\is_resource($dba)) { |
There was a problem hiding this comment.
The fix was shipped with PHP 8.4.2.
392eb5a to
ece56db
Compare
| public static function castGd(\GdImage $gd, array $a, Stub $stub, bool $isNested): array | ||
| { | ||
| $a['size'] = imagesx($gd).'x'.imagesy($gd); | ||
| $a['trueColor'] = imageistruecolor($gd); |
There was a problem hiding this comment.
don't these miss the virtual prefix?
There was a problem hiding this comment.
Virtual prefixes weren't present before the refactoring, but I'm fine adding them, it makes sense
There was a problem hiding this comment.
they weren't present because resource's properties are always virtual
now that we deal with objects, we have to make the virtual explicitly
48619eb to
8c99b6a
Compare
8c99b6a to
7be6483
Compare
|
Thank you @alexandre-daubois. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes up for the backlog of resources transformed into objects in the latest versions of PHP.
✅ Support added (or already existing with an update in
AbstractCloner):CurlMultiHandle: no information to gatherOpenSSLCertificateSigningRequestOpenSSLAsymmetricKeySqlite3ResultSockets(to rebase on [VarDumper] Add caster for Socket instances #59026)PgSql\LobPgSql\ConnectionPgSql\ResultOdbc\ConnectionOdbc\ResultSoap\UrlSoap\Sdl