[HttpFoundation][HttpKernel] Reset request formats after each main request #59047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add public static method to reset Request format to mime mappings Reset Request format to mime mappings on Kernel boot for each new main request
dunglas
requested changes
Dec 1, 2024
| */ | ||
| public static function resetFormats(): void | ||
| { | ||
| static::$formats = null; |
There was a problem hiding this comment.
Suggested change
| static::$formats = null; | |
| static::initializeFormats(); |
This is a micro-optimization, but this will save some time when handling the next request.
There was a problem hiding this comment.
@dunglas I considered doing it this way originally but my feeling was because the initial state of $formats is null, that's what we should set it back to as a reset., because that's the change that interferes least with the implementation details of the rest of the class. Happy to change it in accordance with your suggestion if you like.
|
This should be merged in 6.4 as it's (mostly) a bug fix. |
Fix typo in function docblock Co-authored-by: Kévin Dunglas <[email protected]>
|
Closing as superseded by #59053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add public static method to reset Request format to mime mappings Reset Request format to mime mappings on Kernel boot for each new main request
Adds a new public static method to
Requestto reset the mappings of formats to MIME types. Adds a call to this method just before resetting services inKernel::boot().