Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpClient] Add IPv6 support to NativeHttpClient #59068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2025
Merged

[HttpClient] Add IPv6 support to NativeHttpClient #59068

merged 1 commit into from
Jan 2, 2025
+46 −5

Conversation

dmitrii-baranov-tg
Copy link
Contributor

@dmitrii-baranov-tg dmitrii-baranov-tg commented Dec 2, 2024 •
edited by OskarStark
Loading

Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #59027
License MIT

At the moment, NativeHttpClient works only with IPv4 because of the way it does DNS resolution.
But by taking inspiration from DNS resolution in NoPrivateNetworkHttpClient, we are able to make it IPv6 compatible.

@carsonbot carsonbot added this to the 7.2 milestone Dec 2, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

nicolas-grekas
nicolas-grekas reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for starting this!

@dmitrii-baranov-tg dmitrii-baranov-tg changed the base branch from 7.2 to 7.3 December 3, 2024 05:53
@dmitrii-baranov-tg
Copy link
Contributor Author

Seems like the Windows / x86 / minimal-exts / lowest-php (pull_request) Workflow is flapping, I had it passing before and now it fails with just a CHANGELOG entry being changed:

image

@dmitrii-baranov-tg
Copy link
Contributor Author

@nicolas-grekas Shall we go ahead with the merge or something else needs to be fixed?

@fabpot fabpot modified the milestones: 7.2, 7.3 Dec 30, 2024
@nicolas-grekas
Copy link
Member

Thank you @dmitrii-baranov-tg.

@nicolas-grekas nicolas-grekas merged commit 04ee771 into symfony:7.3 Jan 2, 2025
11 checks passed
@nicolas-grekas nicolas-grekas mentioned this pull request Jan 2, 2025
Closed
@OskarStark OskarStark changed the title [HttpClient] Add IPv6 support to NativeHttpClient [HttpClient] Add IPv6 support to NativeHttpClient Jan 2, 2025
@fabpot fabpot mentioned this pull request May 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexislefebvre alexislefebvre Awaiting requested review from alexislefebvre

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Feature HttpClient Status: Needs Review
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

Add IPv6 support to NativeHttpClient
5 participants
@dmitrii-baranov-tg @carsonbot @nicolas-grekas @alexislefebvre @fabpot