[HttpKernel] [MapQueryString] added key argument to MapQueryString attribute #59157
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
nicolas-grekas
approved these changes
Dec 10, 2024
chalasr
approved these changes
Dec 10, 2024
mtarld
approved these changes
Dec 10, 2024
fabpot
approved these changes
Dec 10, 2024
7fbdfca to
ac1f54c
Compare
|
Thank you @feymo. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 19, 2024
…n (feymo) This PR was merged into the 7.3 branch. Discussion ---------- [HttpKernel] [MapQueryString] Add docs for new key option Will fix #20463 Add documentation for the new `key` option added to `MapQueryString` attribute added in symfony/symfony#59157 Commits ------- 2fdd0db docs(controller): add docs for key option in MapQueryString
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
[#MapQueryString], the default resolver uses the$request->query-all()function but there's currently no way to pass a specific key to this function if needed.This PR add a
$keyargument to the#[MapQueryString]attribute that will allow to pass a specific key if needed to the default resolver.Example :
Given the following query :
https://example.org?search[term]=foo&search[category]=bar, using current#[MapQueryString]implementation will resolve an object with only$searchproperty.Change proposed in this PR allows to pass a
keyargument like#[MapQueryString(key: search)]. Doing so, the object will be resolved with$termand$categoryproperties.