[HttpClient] fix amphp http client v5 unix socket #59320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praswicaksono
commented
Dec 29, 2024
|
|
||
| if ($options['proxy']) { | ||
| $proxyUrl = parse_url($options['proxy']['url']); | ||
| $proxySocket = new SocketAddress($proxyUrl['host'], $proxyUrl['port']); |
Contributor
Author
There was a problem hiding this comment.
this class are not exist in v5
Contributor
Author
|
@nicolas-grekas psalm check fail because it run using php 8.2 and amphp/httpclient v4, should I surpress undefined method error? |
Member
|
No need to, just ignore the message. |
18b6d64 to
a32ebfa
Compare
nicolas-grekas
approved these changes
Jan 1, 2025
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
I moved the test case to HttpClientTestCase to that we run it with curl also.
Member
|
Thank you @praswicaksono. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unix socket connection when using
amphp/http-clientv5@nicolas-grekas