[PropertyInfo] Make sure that SerializerExtractor returns null for invalid class metadata #59367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jan 6, 2025
xabbuh
requested changes
Jan 6, 2025
…or invalid class metadata
df8f3b1 to
7bc832e
Compare
xabbuh
approved these changes
Jan 7, 2025
Member
|
Thank you @wuchen90. |
This was referenced Jan 29, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to call
getPropertieswith a classname that doesn't exist, the classMetadataFactory will break.In this case, this method should return
nullin order to fallback to other instances ofPropertyListExtractorInterfacein case we're accessing thisgetPropertiesmethod with\Symfony\Component\PropertyInfo\PropertyInfoExtractor.