[Mailer] Fix SMTP stream EOF handling on Windows by using feof() #59404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jan 8, 2025
| @@ -84,7 +84,7 @@ public function readLine(): string | |||
| if ($metas['timed_out']) { | |||
| throw new TransportException(sprintf('Connection to "%s" timed out.', $this->getReadConnectionDescription())); | |||
| } | |||
| if ($metas['eof']) { | |||
| if (\feof($this->out)) { | |||
There was a problem hiding this comment.
Suggested change
| if (\feof($this->out)) { | |
| if (feof($this->out)) { |
Maybe we should also add a comment so that this is not changed back again in the future.
66af27c to
ed18c7c
Compare
|
Thank you @skmedix. |
This was referenced Jan 29, 2025
Merged
Merged
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full explanation of this change here: #59351 (comment)
Help with tests would be appreciated.