Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SecurityBundle] Make data provider static #59563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

alexandre-daubois
Copy link
Member

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Data providers should always be static.

@GromNaN
Copy link
Member

GromNaN commented Jan 20, 2025

Is it something we should merge into 6.4 to be able to run newer versions on PHPUnit required for newer versions on PHP? We merged #48668 on the oldest maintained branch at its time.

@stof
Copy link
Member

stof commented Jan 20, 2025

@GromNaN there is no newer version of PHPUnit being required. PHPUnit 9.6 is on life support, so it gets patched for compatibility with newer versions (it won't receive support for mocking classes that use new language features unsupported in PHP versions from the time it was active, but code in the 6.4 branch won't be allowed to use such features anyway)

@alexandre-daubois
Copy link
Member Author

Is it something we should merge into 6.4

The related test was introduced in the beginning of this month anyway 🙂

@derrabus
Copy link
Member

Is it something we should merge into 6.4

If that data provider exists on a lower branch, we can do that in order to keep things consistent.

to be able to run newer versions on PHPUnit

We won't do that. We work towards compatibility with PHPUnit 11, but on the highest branch only.

required for newer versions on PHP?

PHPUnit 9 will receive compatibility patches for newer PHP versions. We don't have to use a newer PHPUnit version just for PHP compatibility.

@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit 05d5bb3 into symfony:7.3 Jan 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants