-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[SecurityBundle] Make data provider static #59563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SecurityBundle] Make data provider static #59563
Conversation
11ad56c
to
b6533df
Compare
Is it something we should merge into 6.4 to be able to run newer versions on PHPUnit required for newer versions on PHP? We merged #48668 on the oldest maintained branch at its time. |
@GromNaN there is no newer version of PHPUnit being required. PHPUnit 9.6 is on life support, so it gets patched for compatibility with newer versions (it won't receive support for mocking classes that use new language features unsupported in PHP versions from the time it was active, but code in the 6.4 branch won't be allowed to use such features anyway) |
b6533df
to
a3c73f8
Compare
The related test was introduced in the beginning of this month anyway 🙂 |
If that data provider exists on a lower branch, we can do that in order to keep things consistent.
We won't do that. We work towards compatibility with PHPUnit 11, but on the highest branch only.
PHPUnit 9 will receive compatibility patches for newer PHP versions. We don't have to use a newer PHPUnit version just for PHP compatibility. |
Thank you @alexandre-daubois. |
Data providers should always be static.