[MonologBridge] Add ability to react to console input being interactive or not #59955
Conversation
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
4ef2980 to
5ac3f1d
Compare
Yes, this is expected to be 100% BC, it's opt-in for 7.x for sure, maybe it makes sense to change that for 8.x, but that's not up to me. |
5ac3f1d to
0fbbc35
Compare
|
Config part symfony/monolog-bundle#504 |
0fbbc35 to
a17b916
Compare
GromNaN
left a comment
There was a problem hiding this comment.
I understand the need behind this feature, and it seems like an interesting solution when you know how to configure it properly: with the console handler before the other handlers that write to standard output.
I think it's necessary to review the conditions and tests. And rebase the branch.
src/Symfony/Bridge/Monolog/Tests/Handler/ConsoleHandlerTest.php
Outdated
Show resolved
Hide resolved
f8a5229 to
f7ca725
Compare
f7ca725 to
6afe9bb
Compare
|
Thank you @dkarlovi. |
…being interactive or not (dkarlovi) This PR was squashed before being merged into the 7.4 branch. Discussion ---------- [MonologBridge] Add ability to react to console input being interactive or not | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix #58715 | License | MIT See #58715 for example. Commits ------- ace9054 [MonologBridge] Add ability to react to console input being interactive or not
This PR was squashed before being merged into the 3.x branch. Discussion ---------- feat: console.interactive_only flag Note: needs symfony/symfony#59955 Closes symfony/symfony#58715 Commits ------- 35a942f feat: console.interactive_only flag
See #58715 for example.