[DoctrineBundle] EntityUserProvider: call to loadUserByUsername from loadUserByAccount #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loadUserByUsername with "$account->getUsername()" parameter instead of "(string) $account"
|
this already seems fixed. |
|
ah sorry .. its fixed in fabpot/master |
dawehner
pushed a commit
to dawehner/symfony
that referenced
this pull request
Jul 1, 2013
Updated to use the renamed RoutingBundle
SofHad
pushed a commit
to SofHad/symfony
that referenced
this pull request
Oct 12, 2015
This PR was merged into the master branch. Discussion ---------- Add show code in view post Commits ------- e00181a Add show code in view post
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Mar 30, 2020
Improve the advisory validator
stobrien89
pushed a commit
to stobrien89/symfony
that referenced
this pull request
Feb 27, 2025
Mark s3 client service definition as lazy
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In EntityUserProvider class, the method loadUserByAccount() was calling loadUserByUsername method with param : "(string) $account". That was forcing the developper to return the username from __toString() method in his AccountInterface implementation.