[Lock] Add LockKeyNormalizer
#60023
Merged
[Lock] Add LockKeyNormalizer
#60023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89d05b7 to
d1cd6e1
Compare
stof
reviewed
Mar 28, 2025
src/Symfony/Component/Lock/Tests/Serializer/LockKeyNormalizerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Jul 21, 2025
090db9a to
be1f46f
Compare
Contributor
Author
|
Since native serialization is handled within EDIT: right, it would not work on deserialization.. |
4264be0 to
9a45e82
Compare
LockKeyNormalizerLockKeyNormalizer
9a45e82 to
4d12197
Compare
fabpot
requested changes
Sep 4, 2025
src/Symfony/Component/Lock/Tests/Serializer/LockKeyNormalizerTest.php
Outdated
Show resolved
Hide resolved
LockKeyNormalizerLockKeyNormalizer
4d12197 to
f9d2893
Compare
f9d2893 to
d773b6c
Compare
fabpot
approved these changes
Sep 6, 2025
Member
|
Thank you @valtzu. |
Member
|
@valtzu another reason: |
This was referenced Oct 27, 2025
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 5, 2025
…nicolas-grekas) This PR was merged into the 7.4 branch. Discussion ---------- [Lock] Fix unserializing already serialized Key payloads | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #62585 | License | MIT Issue introduced in #60023 Commits ------- 44cf8da [Lock] Fix unserializing already serialized Key payloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Lock documentation mentions that the lock keys are serializable – however, it seems that's the case only if you're using native php serializer.
I'm proposing to add
LockKeyNormalizerto make the example in the docs work the same when using Symfony Serializer too.