-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Mailer][TwigBridge] Revert "Add support for translatable objects" #60052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry about that @norkunas. Could #59967 (comment) be a solution? If so, we can document this. |
As we were already introduce a |
I'm not really a fan of this for the reason @nicolas-grekas mentioned in #59967 |
I have no idea what his suggestion is about. It makes no sense for Email to implement TranslatableInterface. On the other hand, supporting translatable subjects is probably a use case for any localized project (and would allow avoiding to inject the translator in each place creating an Email object to translate it before calling |
This was the specific reason I was referring to. I'm thinking to document #59967 (comment) as the best way to translate the subject. I get that it doesn't work if not using Twig, but in this case, you'd have to have an alternate system to translate the body/html - so why not translate subject within the same system. |
Thank you @kbond. |
#59967 introduced a BC break so we need to revert and find another solution.