[HttpCache][WIP] Use RFC9211 Cache-Status #60078
Draft
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Mar 30, 2025
| @@ -29,6 +29,8 @@ class HeaderBag implements \IteratorAggregate, \Countable, \Stringable | |||
| protected array $headers = []; | |||
| protected array $cacheControl = []; | |||
|
|
|||
There was a problem hiding this comment.
Blank line can be removed
| @@ -127,6 +127,7 @@ public function testInvalidatesOnPostPutDeleteRequests() | |||
|
|
|||
| $this->assertHttpKernelIsCalled(); | |||
| $this->assertResponseOk(); | |||
|
|
|||
|
@franckranaivo do you intend to continue this ? Btw, it would be great to update the description of the PR to include some usage examples. It makes the review much easier. |
stof
reviewed
Jun 23, 2025
| @@ -29,6 +29,8 @@ class HeaderBag implements \IteratorAggregate, \Countable, \Stringable | |||
| protected array $headers = []; | |||
| protected array $cacheControl = []; | |||
|
|
|||
| protected array $cacheStatus = []; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to answer #58985 by using Cache-Status directives as described here.