Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Notifier] [Mercure] Add options #60140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Conversation

ernie76
Copy link
Contributor

@ernie76 ernie76 commented Apr 4, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
License MIT

Add content option to MercureTransport

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.3 for features".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@ernie76
Copy link
Contributor Author

ernie76 commented Apr 4, 2025

this PR connect to this PR symfony/ux#1853

@fabpot fabpot force-pushed the NotifierMercure7.3 branch from 843bfcf to d54febf Compare April 4, 2025 09:29
@fabpot
Copy link
Member

fabpot commented Apr 4, 2025

Thank you @ernie76.

@fabpot fabpot merged commit 8a84530 into symfony:7.3 Apr 4, 2025
9 of 11 checks passed
@@ -29,6 +29,7 @@ public function __construct(
private ?string $id = null,
private ?string $type = null,
private ?int $retry = null,
private ?array $content = null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should document the shape supported for that array

@OskarStark OskarStark changed the title Notifier mercure7.3 [Notifier] [Mercure] Add options Apr 4, 2025
@fabpot fabpot mentioned this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants