Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Workflow] Add support for weighted transitions #60201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Oct 1, 2025
Merged

[Workflow] Add support for weighted transitions #60201

nicolas-grekas merged 1 commit into from
Oct 1, 2025

Conversation

@lyrixx
Copy link
Member

@lyrixx lyrixx commented Apr 11, 2025 •
edited by OskarStark
Loading

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? yes
Issues Fix #60107
License MIT

Allow to handle complex workflow like:

make_table:
    transitions:
        start:
            from: init
            to:
                -   place: prepare_leg
                    weight: 4
                -   place: prepare_top
                    weight: 1
                -   place: stopwatch_running
                    weight: 1
        build_leg:
            from: prepare_leg
            to: leg_created
        build_top:
            from: prepare_top
            to: top_created
        join:
            from:
                - place: leg_created
                  weight: 4
                - top_created
                - stopwatch_running
            to: finished
$definition = new Definition(
    [],
    [
        new Transition('start', 'init', [new Arc('prepare_leg', 4), 'prepare_top', 'stopwatch_running']),
        new Transition('build_leg', 'prepare_leg', 'leg_created'),
        new Transition('build_top', 'prepare_top', 'top_created'),
        new Transition('join', [new Arc('leg_created', 4), 'top_created', 'stopwatch_running'], 'finished'),
    ]
);

$subject = new Subject();
$workflow = new Workflow($definition);

$workflow->apply($subject, 'start');

$workflow->apply($subject, 'build_leg');
$workflow->apply($subject, 'build_top');
$workflow->apply($subject, 'build_leg');
$workflow->apply($subject, 'build_leg');
$workflow->apply($subject, 'build_leg');
$workflow->apply($subject, 'join');

Another example, based on https://demo-symfony-workflow.cleverapps.io/articles/show/1
workflow.webm

@carsonbot carsonbot added this to the 7.3 milestone Apr 11, 2025
@lyrixx lyrixx mentioned this pull request Apr 11, 2025
Closed
@lyrixx lyrixx force-pushed the workflow-transition-weight branch from c2a67c1 to 5f46eb6 Compare April 11, 2025 18:06
bkosun
bkosun suggested changes Apr 11, 2025
View reviewed changes
bkosun
bkosun suggested changes Apr 11, 2025
View reviewed changes
@lyrixx lyrixx force-pushed the workflow-transition-weight branch from 5f46eb6 to 9a13aba Compare April 12, 2025 05:35
@lyrixx lyrixx requested a review from bkosun April 12, 2025 05:35
@lyrixx
Copy link
Member Author

lyrixx commented Apr 12, 2025

@bkosun Thanks for the review. I addressed your comments

94noni
94noni reviewed Apr 13, 2025
View reviewed changes
94noni
94noni reviewed Apr 13, 2025
View reviewed changes
stof
stof reviewed Apr 14, 2025
View reviewed changes
@fabpot fabpot modified the milestones: 7.3, 7.4 May 26, 2025
@lyrixx lyrixx force-pushed the workflow-transition-weight branch from 9a13aba to 7758d3d Compare June 4, 2025 10:00
@lyrixx
Copy link
Member Author

lyrixx commented Jun 4, 2025

Thanks for the review, I addressed your comments, and also rebased.

@lyrixx
Copy link
Member Author

lyrixx commented Jun 4, 2025 •
edited
Loading

I don't get why the tests are broken:

4) Symfony\Bundle\FrameworkBundle\Tests\DependencyInjection\YamlFrameworkExtensionTest::testWorkflowAreValidated
Failed asserting that exception of type "ReflectionException" matches expected exception "Symfony\Component\Workflow\Exception\InvalidDefinitionException". Message was: "Class "Symfony\Component\Workflow\Arc" does not exist" at

since I put

  "require-dev": {
      "symfony/workflow": "^7.4|^8.0",

in src/Symfony/Bundle/FrameworkBundle/composer.json

nicolas-grekas
nicolas-grekas reviewed Sep 15, 2025
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase needed + some thoughts.

@lyrixx lyrixx force-pushed the workflow-transition-weight branch from 7758d3d to 15848ab Compare October 1, 2025 10:22
@lyrixx
Copy link
Member Author

lyrixx commented Oct 1, 2025

Comment addressed, an PR rebased

@lyrixx lyrixx force-pushed the workflow-transition-weight branch from 15848ab to a52f9a3 Compare October 1, 2025 12:33
nicolas-grekas
nicolas-grekas approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some CS fixes

@lyrixx lyrixx force-pushed the workflow-transition-weight branch from a52f9a3 to c936834 Compare October 1, 2025 14:41
@nicolas-grekas nicolas-grekas force-pushed the workflow-transition-weight branch from c936834 to 207fc49 Compare October 1, 2025 15:10
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Oct 1, 2025

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit b120f31 into symfony:7.4 Oct 1, 2025
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 1, 2025
Closed
@lyrixx lyrixx deleted the workflow-transition-weight branch October 2, 2025 08:18
This was referenced Oct 27, 2025
Merged
Merged
@nicolas-grekas nicolas-grekas mentioned this pull request Nov 13, 2025
Closed
@xabbuh
Copy link
Member

xabbuh commented Nov 29, 2025

@lyrixx Looking at how we use getFroms()/getTos() I wonder if the idea was to deprecate the argument in 8.1+ and let both methods only return list of Arc instances in 9.0?

@lyrixx
Copy link
Member Author

lyrixx commented Dec 1, 2025

🤔 I don't remember why I did that! I guess I wanted to deprecate things at some point.

Now, I don't think it worth a deprecated. I would open a PR to add real args. What do you think ?

@xabbuh
Copy link
Member

xabbuh commented Dec 1, 2025

I was basically wondering because there are now different places where call these methods with true and afterwards only extract the place so we could as well have left those places untouched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@bkosun bkosun Awaiting requested review from bkosun

+1 more reviewer

@94noni 94noni 94noni left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Deprecation Feature Status: Reviewed Workflow

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

[Workflow] Unexpected marking with a complex workflow after transition

8 participants

@lyrixx @nicolas-grekas @xabbuh @stof @94noni @bkosun @fabpot @carsonbot