[Lock] Add namespace support to Redis & Memcache lock stores #60227
Conversation
This comment has been minimized.
This comment has been minimized.
| public function __construct( | ||
| private \Redis|Relay|RelayCluster|\RedisArray|\RedisCluster|\Predis\ClientInterface $redis, | ||
| private float $initialTtl = 300.0, | ||
| private array $options = [], |
There was a problem hiding this comment.
why use an array of options rather than give the namespace directly?
There was a problem hiding this comment.
I prefer to use namespace parameter directly, but I tried to keep style similar to other stores (DoctrineDbalStore, MongoDbStore, PdoStore, PostgreSqlStore)
|
|
||
| $matches = []; | ||
| $namespace = ''; | ||
| if (preg_match('/^(.*[\?&])namespace=([^&#]*)&?(([^#]*).*)$/', $connection, $matches)) { |
There was a problem hiding this comment.
can't we use parse_url instead of this logic?
also, don't we need something similar on MemcachedStore?
There was a problem hiding this comment.
It's general to both stores (StoreFactory class).
parse_url cant be used here, because redis dsn string is not always URL format compatible. Also this approach is used in MongoDbStore (collection paramerer), with "options" array as well.
4994f37 to
788c1c1
Compare
|
@nicolas-grekas can you resolve your comments? |
Co-authored-by: Oskar Stark <[email protected]>
|
Not actual since ^7.2 there are option to pass custom connection to StoreFactory, i.e: |
Sometimes we need use shared redis cluster between applications. By security reasons we allow each application to access only own keys. Cache component can deal with it, lock - is not.