-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] Rabbitmq delayed quorum queues #60298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.2
Are you sure you want to change the base?
[Messenger] Rabbitmq delayed quorum queues #60298
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
I've already done it in a nodeJS project and it works well in production. async function createDelayedQueue(channel, exchange, queue, delay) {
const date = new Date().toISOString().split('T')[0];
const delayedQueue = `delay_${exchange}_${queue}_${delay}_${date}`;
const delayedExchange = 'delays';
const baseExpire = 24 * 60 * 60 * 1000;
await channel.assertQueue(delayedQueue, {
durable: true,
arguments: {
'x-message-ttl': delay,
'x-expires': delay + 60 * 1000 + baseExpire,
'x-dead-letter-exchange': exchange,
'x-dead-letter-routing-key': queue,
'x-queue-type': 'quorum'
}
});
await channel.bindQueue(delayedQueue, delayedExchange, delayedQueue);
return { delayedQueue, delayedExchange };
} |
This probably also affect 6.4, right? |
Yes, that's right |
Sorry, I've tried to change the base branch to 6.4 and by mistake it has added automatically the reviewers, feel free to leave 🙏 |
No worries, we can target 6.4 while merging this PR 👍 |
As described in the issue: #57867 when we create delayed quorum queues this doesn't update the expire time.
I've first tried what is suggested by rabbit maintainers here: rabbitmq/rabbitmq-server#5894 (comment) but it doesn't supported either.
So the final solution is create a delayed quorum queue per day, with expire of one day + ttl + 10 seconds, with this approach, when you enqueue a message to a delayed queue, you'll be sure that all the delayed message of the same day will be in the same queue and this queue won't die before the last message is processed.
For example you delay a message with 10s delay at 10:00 of 2025-04-29, this will create a delayed queue named:
delay_test_test_delay_2025-04-29 with expire on 2025-04-30 at 10:10:10.
If another message comes at 23:59:59, it will go to the same queue, that is already created.
And in the next day will create a new queue for the 30th.