[Routing] Deprecate RouteCollection overriding its routes' properties
#60343
+176
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RouteCollection overriding its routes' propertiesRouteCollection overriding its routes' properties
|
The idea is rather not to let these methods change a property which is already defined at the route level. |
|
In my mind the collections’ properties already are the default for their routes’ so I’m not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Symfony, route collections’ methods, schemes, host, defaults, requirements and condition end up overriding their routes’ which is counter-intuitive: it means e.g. every route in a collection whose method is
POSTwill have the same, even if they were configured through theRouteattribute with aGETmethod.Even if doing this has currently no effect and is probably a mistake, changing this behavior would be a BC break so this PR starts by deprecating it.
Then, #53171 can be fixed in 8.0 by changing the conditions and moving the call to routes’ setter into it, e.g.
foreach ($this->routes as $route) { - if ('' !== $route->getHost() && $route->getHost() !== $pattern) { - trigger_deprecation('symfony/routing', '7.3', 'Overriding a route\'s host with its group\'s is deprecated, you should remove it from the route.'); + if ('' === $route->getHost()) { + $route->setHost($pattern); } - $route->setHost($pattern); }I’ll be waiting for an approval before updating loaders tests because it looks like it’ll be tedious.