[Console] Ensure overriding Command::execute() keeps priority over __invoke()
#60361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
May 6, 2025
chalasr
approved these changes
May 6, 2025
|
Thank you @GromNaN. |
OskarStark
reviewed
May 6, 2025
| }; | ||
|
|
||
| $command->run(new ArrayInput([]), new NullOutput()); | ||
| $this->assertSame('execute', $command->called); |
There was a problem hiding this comment.
This tests only if it was called, but in theory the other method could be called before
There was a problem hiding this comment.
Only it was the last called. I assumed that was enough to cover the feature.
There was a problem hiding this comment.
But priority means it should be the first called method, right?
There was a problem hiding this comment.
In practice, only one of them can be called by Command::run()
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #60353 (comment)