[FrameworkBundle] Ensure Email class exists before using it
#60373
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4,". Cheers! Carsonbot |
Kocal
commented
May 7, 2025
| @@ -1067,7 +1067,7 @@ private function addValidationSection(ArrayNodeDefinition $rootNode, callable $e | |||
| ->validate()->castToArray()->end() | |||
| ->end() | |||
| ->scalarNode('translation_domain')->defaultValue('validators')->end() | |||
| ->enumNode('email_validation_mode')->values(Email::VALIDATION_MODES + ['loose'])->end() | |||
| ->enumNode('email_validation_mode')->values((class_exists(Email::class) ? Email::VALIDATION_MODES : ['html5-allow-no-tld', 'html5', 'strict']) + ['loose'])->end() | |||
There was a problem hiding this comment.
Since I believe email_validation_mode won't be used if symfony/mailer is not installed, maybe we can just keep it empty:
Suggested change
| ->enumNode('email_validation_mode')->values((class_exists(Email::class) ? Email::VALIDATION_MODES : ['html5-allow-no-tld', 'html5', 'strict']) + ['loose'])->end() | |
| ->enumNode('email_validation_mode')->values(class_exists(Email::class) ? Email::VALIDATION_MODES + ['loose'] : [])->end() |
There was a problem hiding this comment.
I would keep it the way you changed it here for the same reason we kept loose in #60365, let's better be defensive here as we don't know how people configured their applications
xabbuh
approved these changes
May 7, 2025
GromNaN
approved these changes
May 7, 2025
fabpot
approved these changes
May 8, 2025
|
Thank you @Kocal. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the dev-tests suite from Symfony UX broke after #60365, see: