Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpKernel] MapEntityCollection concept #60450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 7.4
Choose a base branch
from
Open

[HttpKernel] MapEntityCollection concept #60450

wants to merge 3 commits into from
+369 −0

Conversation

evgenij-vy
Copy link

@evgenij-vy evgenij-vy commented May 18, 2025 •
edited by OskarStark
Loading

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #60451
License MIT

Hi everybody. It seems that Symfony needed a smart resolver for entity collection.
It's concept, and if it is really interesting for the community, I'll continue working.
Example to use:

public function __invoke(
    #[MapEntityCollection(
        class: SomeEntity::class,
        queryString: 'queryString',
        queryMapping: ['someQueryProperty' => 'someEntityProperty'],
        doctrineParameters: ['entityProperty' => 'someValue'],
        filters: [
            MyCustomFilter::class,
        ],
        defaultOrdering: ['id' => 'ASC']
    )]
    iterable $collectionEntity,
    #[MapQueryString]
    QueryStringObject $queryString,
)
{
}

@carsonbot carsonbot added this to the 7.3 milestone May 18, 2025
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot

This comment was marked as outdated.

Sign in to view
@evgenij-vy evgenij-vy mentioned this pull request May 18, 2025
Open
@OskarStark OskarStark changed the title [HttpKernel] MapEntityCollection concept [HttpKernel] ´MapEntityCollection´ concept May 22, 2025
@fabpot fabpot modified the milestones: 7.3, 7.4 May 26, 2025
@HypeMC
Copy link
Member

HypeMC commented Jun 13, 2025

@evgenij-vy I haven't looked into this too deeply, just wanted to make sure you're aware of #53365.

@evgenij-vy
Copy link
Author

@evgenij-vy I haven't looked into this too deeply, just wanted to make sure you're aware of #53365.

Yes, I know, but I think Symfony should have a feature for simply resolving to a collection of entities like ApiPlatform

@OskarStark OskarStark changed the title [HttpKernel] ´MapEntityCollection´ concept [HttpKernel] MapEntityCollection concept Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature HttpKernel Status: Needs Review
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

[HttpKernel] MapEntityCollection concept
4 participants
@evgenij-vy @carsonbot @HypeMC @fabpot