-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Mailer] Fix memory leak with mailer.message_logger_listener
#60515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mailer.message_logger_listenermailer.message_logger_listener
mailer.message_logger_listenermailer.message_logger_listener
25de67d to
cd941d3
Compare
|
CI failure is unrelated |
|
For the référence comment with #60243 |
|
@andrew-demb Are you still interested in working on this PR? |
cd941d3 to
de857a6
Compare
|
@fabpot yeah, sure. Thanks for the ping. PR updated. |
|
nice 👍🏻 |
de857a6 to
a0415bb
Compare
|
Reclassified these changes to bugfix - changed target branch, updated PR description, dropped entry from the changelog. |
src/Symfony/Component/Mailer/EventListener/MessageLoggerListener.php
Outdated
Show resolved
Hide resolved
a0415bb to
b63317d
Compare
|
Thank you @andrew-demb. |
|
This seems to make the wrong assumption that the |
|
Because of this change We had to make the following change: |
Register
mailer.message_logger_listeneronly when profiler enabled to prevent memory leaks as suggested in:@stof can you guide me about the way how to implement your second suggestion too? #50580 (comment)UPD: resolvedThis change may be considered as a minor BC break - DI service won't be available anymore with disabled profiler.