-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[AssetMapper] add "full" type for packages to download all content #60545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.4". Cheers! Carsonbot |
5403809 to
5a74e2c
Compare
this one too
5a74e2c to
2efdbb1
Compare
|
Could you give an example to illustrate ? |
|
all js/css lib to require without esm. example : #57604 With the flex update, it will be possible to require external js and css from a bundle |
|
So... I'll quote the documentation of AssetMapper here
Then this should not be done in the importmap command / classes. As it is fundamentally different from what this package is about. I don't think we would add a sendSms() method in the Mailer package. This is the same level of difference
This is outside importmap responsibility, and should imho stay that way. ImportMap package is made to handle.... import maps (meaning modules).
But bringing "hidden features"* in AssetMapper / ImportMap because it feels a "quick way" to do things from the bundle editor perspective seems weird to me.. what i mean by hidden features is "things never asked by end-users, or that are outside the scope of this component, and that are only technical methods for one goal: automate download of assets for bundle editors wanting to force that after composer install -- again, not the goal of this component. -- On the implementation side, i think it would be best to isolate this code in another part of the component. Correct me if I miss understood something here, but as i read the PR code, "full" type does not seem to be a package type like the existing others and i'm not sure we should have it mixed with CSS and JS, that are used for other purpose here. Using it as command option would allow unpredictable things like asking for a CSS file as FULL type, right? |

This PR allow AssetMApper to deal with "no modules" libraries,
When we want to require a JS/CSS lib witch doen't have js module, we must import all files to download them.
But in a furthurer version, if one file is added or removed we can skip it.
With the new type "full", Assetmapper can read package contents files and download all of them.