[Notifier][Clicksend] Fix lack of recipient in case DSN does not have optional LIST_ID param #60588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
OskarStark
reviewed
May 30, 2025
src/Symfony/Component/Notifier/Bridge/ClickSend/Tests/ClickSendTransportTest.php
Outdated
Show resolved
Hide resolved
|
It looks like your commiter mail address is not associated with your GitHub account: |
…ameter. According to https://developers.clicksend.com/docs/messaging/sms/other/send-sms#other/send-sms/t=request&path=messages/list_id we need to provide the "to" parameter or the "list_id" parameter. Also fixed forwarding FROM_EMAIL parameter to request.
03a8fd2 to
207e2f9
Compare
|
Thank you @leefant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the ClickSend Notifier bridge where a message would fail to send if the DSN does not include the optional
LIST_IDparameter.According to the [ClickSend API documentation] (https://developers.clicksend.com/docs/messaging/sms/other/send-sms/#request&path=messages/list_id), either the
tofield or alist_idmust be present. In some cases, thelist_idmay be omitted, and the transport must fall back to thetorecipient value instead.Also added forwarding the
FROM_EMAILvalue to the request. Because following code in line 78 looks like typo:$options['from_email'] ?? $this->fromEmail;