[DependencyInjection] add `factory` argument in the `#[Autoconfigure]` attribute and also enabled the use of `factory` within `instanceof` conditionals #60589

santysisi · 2025-05-30T02:28:38Z

Q	A
Branch?	7.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	no
License	MIT

This PR adds support for a new factory argument in the #[Autoconfigure] attribute. It also enables the use of factory in instanceof conditionals across all configuration formats.

The factory argument allows developers to specify how the service should be instantiated, using the same factory syntax already supported in service definitions.

✅ Usage Example

<?php

namespace App\Service;

use Symfony\Component\DependencyInjection\Attribute\Autoconfigure;

#[Autoconfigure(factory: '@=service("app.factory.expression").make()')]
class WithExpressionFactory
{
    public function __construct(public readonly string $foo) {}
}

#[Autoconfigure(
    bind: ['$foo' => 'bar'],
    factory: ['@App\\Factory\\InstanceFactory', 'build']
)]
class WithInstanceMethodFactory
{
    public function __construct(public readonly string $foo) {}
}

#[Autoconfigure(
    bind: ['$foo' => 'baz'],
    factory: '@App\\Factory\\InvokableFactory'
)]
class WithInvokableFactory
{
    public function __construct(public readonly string $foo) {}
}

#[Autoconfigure(
    bind: ['$foo' => 'qux'],
    factory: [\App\Factory\StaticFactory::class, 'create']
)]
class WithStaticFactory
{
    public function __construct(public readonly string $foo) {}
}

#[Autoconfigure(
    bind: ['$foo' => 'auto'],
    factory: [null, 'fromValue']
)]
class WithSelfStaticFactory
{
    public function __construct(public readonly string $foo) {}

    public static function fromValue(string $foo): static
    {
        return new self($foo);
    }
}

zolex · 2025-05-30T04:14:47Z

I like the feature and I know the As prefix for these attributes is common in symfony, but I wonder a bit about the semantics. Usually if I see a AsSomething attribute on a class, it means that the class with the attribute now is a Something. When null is passed as the class to the factory argument, the semantics are fine. But if you provide another classname, a service or even expression language, the As prefix seems semantically incorrect to me, because now it is not the class with the attribute that becomes the factory, but something else. So in the first place I would suggest to rename the Attribute to just Factory.

But thinking about it a bit more: I believe it would be a better option to reuse the existing Autoconfigure attribute, which has a constrcutor argument, that can be used for factories in the same class. At the moment it only allows a string, referencing a static method inside the same class. You could simply apply your logic on the existing attribute argument if it is an array.

santysisi · 2025-05-30T14:09:56Z

Hi @zolex, thanks for your comment ❤️ I really appreciate it 😄
You're absolutely right, the semantics of the As prefix can be misleading, especially when an external factory is used. Renaming the attribute to just Factory makes a lot more sense.
I also really like your suggestion about reusing the existing Autoconfigure attribute. I’ll work on updating it to support arrays and apply the logic there as well.
I’ll make these changes as soon as possible. Thanks again for the valuable feedback! 🙏

santysisi · 2025-06-07T17:31:48Z

I was thinking a bit about this, and I have a question 🤔
If we change the constructor argument to accept string|array|null, I believe we would end up with the same behavior as the factory.
So, my question is: maybe we can leave the constructor argument as it is today, and instead, add the factory argument to the AutoConfigure?

I’m asking this from a place of curiosity and ignorance, totally open to discussion if I’m missing something 🙂
Thanks! ❤️

zolex · 2025-06-07T18:25:44Z

I was thinking a bit about this, and I have a question 🤔 If we change the constructor argument to accept string|array|null, I believe we would end up with the same behavior as the factory. So, my question is: maybe we can leave the constructor argument as it is today, and instead, add the factory argument to the AutoConfigure?

I would definitely prefer the argument to be called factory. If you introduce a factory argument, maybe also support a string for a method in the same class like constructor does and at the same time deprecate the constructor argument to prepare the people to migrate to the factory argument. It was a bad naming anyway.

santysisi · 2025-06-07T18:49:49Z

I like that idea 😄 If others agree, I can go ahead and make that change:

Add a new argument called factory
Deprecate the constructor argument to help people migrate smoothly

santysisi · 2025-06-18T23:21:31Z

Hi 👋 I hope you're all doing well ❤️

I've updated the PR description and made the necessary code changes. Please let me know if there's anything else you'd like me to adjust 😊

P.S. I haven’t deprecated the constructor argument yet but if you all agree that it should be deprecated, I’m happy to make that change as well.

P.P.S. The test failure doesn’t seem related to this PR, it looks like a flaky test.

Thanks! 😄

norkunas · 2025-06-19T05:20:33Z

PR/commit title does not reflect your code here :)

stof · 2025-06-19T12:01:22Z

src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php

@@ -100,6 +100,7 @@ class YamlFileLoader extends FileLoader
        'autowire' => 'autowire',
        'bind' => 'bind',
        'constructor' => 'constructor',
+        'factory' => 'factory',


Why does this change the YamlFileLoader when the PR description talks only about attributes ?

the code internally uses the YamlFileLoader to read values found in attributes

this makes me wonder about the yaml + xml + php config formats: they should also support this factory entry

then we should indeed support it in all formats, and make the changelog entry (and the PR title and description) mention that explicitly.

and we should also have tests preventing regressions for those other formats.

Hi @stof @nicolas-grekas 👋 I hope you're both doing well! 😊
I've made the requested changes, please let me know if there's anything else you'd like me to adjust. 😊

Thanks! ❤️

…` attribute and allow instanceof factory

carsonbot added Status: Needs Review DependencyInjection Feature labels May 30, 2025

carsonbot added this to the 7.4 milestone May 30, 2025

santysisi force-pushed the feature/as-factory-attribute branch 2 times, most recently from e09532c to 52cdb9a Compare May 30, 2025 03:25

nicolas-grekas added Status: Needs Work and removed Status: Needs Review labels May 30, 2025

santysisi force-pushed the feature/as-factory-attribute branch 2 times, most recently from dd83b21 to 5b8b26d Compare June 18, 2025 23:03

stof reviewed Jun 19, 2025

View reviewed changes

santysisi force-pushed the feature/as-factory-attribute branch from 5b8b26d to 39fae23 Compare June 20, 2025 17:25

[DependencyInjection] add factory argument in the `#[Autoconfigure]…

138b1dd

…` attribute and allow instanceof factory

santysisi force-pushed the feature/as-factory-attribute branch from 39fae23 to 138b1dd Compare June 20, 2025 17:28

santysisi changed the title ~~[DependencyInjection] add #[AsFactory] attribute~~ [DependencyInjection] add factory argument in the #[Autoconfigure] attribute and also allow factory in instanceof Jun 20, 2025

santysisi mentioned this pull request Jun 20, 2025

[DependencyInjection] add explanation for attribute option in factories.rst symfony/symfony-docs#21108

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[DependencyInjection] add `factory` argument in the `#[Autoconfigure]` attribute and also enabled the use of `factory` within `instanceof` conditionals #60589

[DependencyInjection] add `factory` argument in the `#[Autoconfigure]` attribute and also enabled the use of `factory` within `instanceof` conditionals #60589

santysisi commented May 30, 2025 •

edited

Loading

Uh oh!

zolex commented May 30, 2025 •

edited

Loading

Uh oh!

santysisi commented May 30, 2025

Uh oh!

santysisi commented Jun 7, 2025

Uh oh!

zolex commented Jun 7, 2025

Uh oh!

santysisi commented Jun 7, 2025

Uh oh!

santysisi commented Jun 18, 2025

Uh oh!

norkunas commented Jun 19, 2025 •

edited

Loading

Uh oh!

stof Jun 19, 2025

Uh oh!

nicolas-grekas Jun 19, 2025

Uh oh!

stof Jun 19, 2025

Uh oh!

stof Jun 19, 2025

Uh oh!

santysisi Jun 20, 2025

Uh oh!

Uh oh!

Uh oh!

[DependencyInjection] add factory argument in the #[Autoconfigure] attribute and also enabled the use of factory within instanceof conditionals #60589

Are you sure you want to change the base?

[DependencyInjection] add factory argument in the #[Autoconfigure] attribute and also enabled the use of factory within instanceof conditionals #60589

Conversation

santysisi commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Usage Example

Uh oh!

zolex commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

santysisi commented May 30, 2025

Uh oh!

santysisi commented Jun 7, 2025

Uh oh!

zolex commented Jun 7, 2025

Uh oh!

santysisi commented Jun 7, 2025

Uh oh!

santysisi commented Jun 18, 2025

Uh oh!

norkunas commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stof Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

stof Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

stof Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

santysisi Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

[DependencyInjection] add `factory` argument in the `#[Autoconfigure]` attribute and also enabled the use of `factory` within `instanceof` conditionals #60589

[DependencyInjection] add `factory` argument in the `#[Autoconfigure]` attribute and also enabled the use of `factory` within `instanceof` conditionals #60589

santysisi commented May 30, 2025 •

edited

Loading

zolex commented May 30, 2025 •

edited

Loading

norkunas commented Jun 19, 2025 •

edited

Loading